Proposals: Enable diff visualization of old versions #949
Conversation
fernandoabolafio
force-pushed
the
propVersion
branch
from
f2cd75d
to
d48e303
Compare
src/components/snew/Markdown/Diff.js
Outdated
| } | ||
| onToggleFIlesDiff = e => { | ||
| e.preventDefault(); | ||
| this.setState({ |
There was a problem hiding this comment.
Prefer passing an updater function as a param to setState when updating state based on the previous state. https://reactjs.org/docs/react-component.html#setstate
src/components/snew/Markdown/Diff.js
Outdated
| filesDiff: false | ||
| }; | ||
| } | ||
| onToggleFIlesDiff = e => { |
There was a problem hiding this comment.
Should be hanleToggleFilesDiff
src/components/snew/Markdown/Diff.js
Outdated
| </Modal> | ||
| ); | ||
| class Diff extends React.Component { | ||
| constructor(props) { |
There was a problem hiding this comment.
This constructor is useless. state = { filesDiff: false } should do the work.
| }; | ||
|
|
||
| getProposalFilesWithourIndexMd = proposal => { | ||
| if (!proposal) return []; |
There was a problem hiding this comment.
This could be a ternary operator. return proposal ? proposal.files.filter(file => file.name !== "index.md") : []
| import { getTextFromIndexMd, formatDate } from "../../../helpers"; | ||
|
|
||
| class ProposalVersionDiff extends React.Component { | ||
| constructor(props) { |
There was a problem hiding this comment.
This constructor is useless.
|
Cool, the code looks good to me now. Thanks!
Also, the select component is not updating the version when one is selected. We could change the cursor to
|
|
@tiagoalvesdulce thanks for the comments. I've replaced the version picker component to a better-suited UI, a dropdown. This is how it looks now: |
|
Cool, looks way better now. |
This PR enables diff visualization of old proposals versions
closes #939