politeiavoter: Retry on failed req due to URL err. #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
pivoter_retry_on_url_err
branch
from
f35f8f8
to
c01ed0a
Compare
This checks the error returned when making a request to specifically detect a *url.Error, which can often happen on Tor for various reasons, and convert it to a retry error so that code which deals with retries will properly retry the request.
davecgh
force-pushed
the
pivoter_retry_on_url_err
branch
from
c01ed0a
to
8c88fcc
Compare
marcopeereboom
approved these changes
Dec 7, 2018
lukebp
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks the error returned when making a request to specifically detect a
*url.Error, which can often happen on Tor for various reasons, and convert it to a retry error so that code which deals with retries will properly retry the request.