[launcher] Add pipetx to wallet on win32 platform #2017
Merged
+148
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading to electron 4+, libuv now provides the appropriate function so that the file descriptor can be exported from the win32ipc module and used during the launching process in windows.
|
Rebased and re-tested after #2009 merge. |
alexlyp
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2009This adds the pipetx flag to wallet initialization when running on the windows platform, so that the app can perform correct fetching of the grpc port during wallet startup and allows us to get rid of port detection via logs, which is brittle.
This requires the app to be compiled with an electron version 4 or higher, due to the correct function only being available on libuv 1.23+.
When testing this you might need to remove the entire
node_modulesandapp/node_modulesfor the correct version of the module to be compiled. The win32ipc module does not work when usingyarn build && yarn start, only with eitheryarn devoryarn package.Close #1712.