Exit alert ticketbuyer running #1989
Merged
+106
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2019 16:17
szpasztor
commented
Jan 16, 2019
| @@ -51,23 +56,13 @@ class App extends React.Component { | |||
| this.props.showAboutModalMacOS(); | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| beforeWindowUnload(event) { | |||
There was a problem hiding this comment.
Removed the whole block as it seemed to have no use with the new exit logic. According to this thread, it's not recommended to override this event. It's also undocumented in electron.
|
Seems like there's an issue with powerSaveBlocker on macOS, I opened an bug report about it. |
added 10 commits
January 24, 2019 15:29
# Conflicts: # app/containers/App.js # app/main.development.js # app/main_dev/templates.js
|
Ready for review. |
matheusd
approved these changes
Feb 19, 2019
alexlyp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1923
Tasks
prevent & alert when entering suspend mode