Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[watch only] Watch only transaction #1864

Merged
merged 5 commits into from Dec 11, 2018
Merged

Conversation

vctt94
Copy link
Member

@vctt94 vctt94 commented Dec 4, 2018

closes #1682

I need to rebase, so if can test in trezor mode, that would be great.

@matheusd
Copy link
Member

matheusd commented Dec 5, 2018

Only small issue is that in trezor-enabled wallets, you shouldn't show the unsigned transaction, but rather continue with the signing flow (which should send the sign request to trezor).

You can manually set a wallet as using trezor (to test out the behavior, even if you can't sign it) by modifying the wallet's config.json (not the global one) to have trezor: true.

@vctt94
Copy link
Member Author

vctt94 commented Dec 5, 2018

fixed

@vctt94 vctt94 changed the title Watch only transaction [watch only] Watch only transaction Dec 5, 2018
@matheusd
Copy link
Member

matheusd commented Dec 6, 2018

I'm still seeing the raw constructed transaction on the trezor wallet, which is unnecessary.

@vctt94
Copy link
Member Author

vctt94 commented Dec 7, 2018

My bad. Removed it now.

One thing I noticed, is that when in trezor mode, the wallet seems to not turn it off, when switching between wallets.

@matheusd
Copy link
Member

matheusd commented Dec 7, 2018

Yeah, I had noticed that bug earlier in regards to the sidebar. Fixed in #1876.

One last nit: transactions can be big and overflow the white area (eg):

screenshot_2018-12-07_11-59-42

@vctt94
Copy link
Member Author

vctt94 commented Dec 7, 2018

fixed

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be nice to have!

@alexlyp alexlyp merged commit a5c6a5e into decred:master Dec 11, 2018
@vctt94 vctt94 deleted the watchOnlyTransaction branch December 13, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow watch only wallets to construct transactions
3 participants