Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[politeia] Notifications for new proposals and votes #1835

Merged
merged 7 commits into from Nov 27, 2018

Conversation

matheusd
Copy link
Member

Close #1832
Part of #1808

This

  • Changes to fetch politeia proposals after wallet startup without having to enter the governance page
  • Adds two new config entries to store the latest timestamp and block height when politeia data was successfully fetched
  • Uses those two config items to determine whether a vetted or active vote proposal are new ones (either newly vetted or newly voting)
  • Shows the appropriate notification ui

There's an outstanding issue due to decred/politeia#618: Given we only have the timestamp for proposal creation (vs proposal vetting for discussion) this version has a bug in that proposals that have been vetted after the user has fetched the latest batch of proposals will not be marked as modifiedSinceLastAccess (because the user has already passed through the block height of the proposal creation).

Alternatives for this are:

  • Wait for Return vet timestamp on /vetted politeia#618 to be solved, and than change which timestamp is used to determine new proposals (preferred method)
  • Locally store the proposals that have been seen and check after loading the proposal list whether this has been seen

@alexlyp
Copy link
Member

alexlyp commented Nov 27, 2018

I think it's reasonable to just wait until 618 is solved to determine the new proposals

Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with new proposals on testnet and everything looks great!

@alexlyp alexlyp merged commit 01557f3 into decred:master Nov 27, 2018
@matheusd matheusd deleted the politeia-notifs branch November 27, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants