Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launcher] Add SPV Choice page #1766

Merged
merged 7 commits into from Nov 1, 2018
Merged

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Nov 1, 2018

Close #1755

Fully functional, but still trying to finalize some of the copy on the explanation of SPV vs Regular.

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on regular mode and advanced mode and everything is working nice.

I have just one comment, but it is not really related with this PR, so we can have an issue for that.

When spv is activated, the message waiting for daemon connection still shows. I think we should remove that when in spv.

@vctt94
Copy link
Member

vctt94 commented Nov 1, 2018

good job!

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fine as well.

Only thing I'd suggest is a link to a specific document on docs.decred.org fully describing what spv mode entails, but otherwise I think the copy is reasonable for users.

@alexlyp
Copy link
Member Author

alexlyp commented Nov 1, 2018

Agree on that. I'll add an issue to address this in the future.

@alexlyp alexlyp merged commit c995973 into decred:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants