Remove v1 ticketbuyer in favor of v2 module. #1396
Merged
+22
−2,431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
removetbv1
branch
3 times, most recently
from
ba444d6 to
d7c593f
Compare
All v1-specific config options have been deprecated for several releases. These options are no longer present after the module removal. In addition to the removal of the v1 module, the startautobuyer and stopautobuyer methods of the JSON-RPC server have been removed. This is due to the v2 buyer being controlled exclusively by the main package when --enableticketbuyer is set and because these RPCs contained many v1-specific options while failing to specify the account to purchase from. Multiple v2 ticketbuyer instances are still possible control through the gRPC API.
davecgh
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All v1-specific config options have been deprecated for several releases. These
options are no longer present after the module removal.
In addition to the removal of the v1 module, the startautobuyer and
stopautobuyer methods of the JSON-RPC server have been removed. This is due to
the v2 buyer being controlled exclusively by the main package when
--enableticketbuyer is set and because these RPCs contained many v1-specific
options while failing to specify the account to purchase from. Multiple v2
ticketbuyer instances are still possible control through the gRPC API.