jsonrpc/types: Implement new module for dcrjson. #1394
Merged
+3,782
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Feb 14, 2019
davecgh
force-pushed
the
dcrjson_jsonrpc_types
branch
2 times, most recently
from
5d77028 to
478c37f
Compare
This moves all of the types specific to dcrwallet from the dcrjson module into a new module at rpc/jsonrpc/types so wallet is able to independently modify them as necessary without needing to submit the changes to dcrd directly or requiring new dcrjson tags. It provides full package documentation and also ported all tests over so there is comprehensive test coverage.
davecgh
force-pushed
the
dcrjson_jsonrpc_types
branch
from
478c37f to
1195e2d
Compare
|
I've updated this to remove the override now that the requisite module is tagged. |
jrick
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires decred/dcrd#1607.
DO NOT MERGE -- This currently contains an override in thego.modto use the required pull request so CI will build. It will need to be updated once the upstream PR is merged and tagged.This moves all of the types specific to
dcrwalletfrom thedcrjsonmodule into a new module atrpc/jsonrpc/typesso wallet is able to independently modify them as necessary without needing to submit the changes todcrddirectly or requiring newdcrjsontags.It provides full package documentation and also ported all tests over so there is comprehensive test coverage.