rpc: use SOCKS5 proxy if configured #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Oct 1, 2018
jrick
requested changes
Oct 8, 2018
chain/chain.go
Outdated
| // operate on the same decred network as described by the passed chain | ||
| // parameters, the connection will be disconnected. If proxypath is not empty, | ||
| // it will be used to connect. | ||
| func NewClient(chainParams *chaincfg.Params, connect, user, pass string, certs []byte, |
There was a problem hiding this comment.
If NewClientConfig is exported, I don't see any reason to also include this.
There was a problem hiding this comment.
One reason is that any caller of NewRPCClientConfig will need to import dcrrpcclient package, and any user of NewRPCClient can simply update to using NewClient (with SOCKS support) without changing too much code.
There was a problem hiding this comment.
It's a transient dependency anyways, making it an explicit import doesn't change anything and adds less cruft to the public API.
chain/chain.go
Outdated
|
|
||
| // NewClientConfig creates a client connection to the server described by the | ||
| // passed chainParams and connConfig | ||
| func NewClientConfig(chainParams *chaincfg.Params, connConfig *dcrrpcclient.ConnConfig) (*RPCClient, error) { |
There was a problem hiding this comment.
nitpick: can you rename this to NewRPCClientConfig for more similarity with the existing NewRPCClient?
jrick
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are config options and flags that currently exist for using SOCKS proxy, but don't do anything.
This exports
NewRPCClientConfig, which creates an RPC Client to thechainpackage and uses it in dcrwallet command.NewRPCClientConfigaccepts adcrrpcclient.ConnConfigfor even more precise configurationResolves #1287