[ filesystem backend] Add dcrtime database fsck #46
+1,039
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebp
approved these changes
Feb 14, 2019
lukebp
reviewed
Feb 15, 2019
lukebp
approved these changes
Feb 15, 2019
marcopeereboom
force-pushed
the
fsck
branch
2 times, most recently
from
a29a808 to
602b11e
Compare
lukebp
approved these changes
Feb 18, 2019
marcopeereboom
changed the title
dajohi
requested changes
Feb 19, 2019
dajohi
approved these changes
Feb 22, 2019
This fsck travels into all directories in a filesystem dcrtime database and ensures that all hashes and timestamps are consistent. It also verifies that flushed records are in fact stored on the blockchain and verifies the merkle roots in the flush record and reality. It currently fixes data errors caused by three bugs. These bugs have since been fixed but the data incoherence was never corrected. The fsck has a journaling function which records all actions taken. This is useful in case at a later time there needs to be a correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code goes through all timestamp directories and verifies that the contents match the global database and the flush record. It identified some results of bugs that were fixed during the duration of the live version.