Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Politeia docs #758

Merged
merged 4 commits into from Dec 26, 2018
Merged

Updates Politeia docs #758

merged 4 commits into from Dec 26, 2018

Conversation

s-ben
Copy link
Contributor

@s-ben s-ben commented Dec 18, 2018

Now that we've had Pi running for a while (and have updated copy in the Pi modal), it's time to updated and flesh out the Pi documentation on dcrdocs. This PR:

@xaur
Copy link

xaur commented Dec 18, 2018

+1 for proposal guidelines page, it will be possible to link it compared to current copy buried in some .js file on github.

@xaur
Copy link

xaur commented Dec 18, 2018

Created decred/politeiagui#947 to extract the .md files with the docs.

P.S. Such meta planning and discussion shall better happen in an issue, while pull requests are used for concrete implementation steps and link to the meta issue.

docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia.md Outdated Show resolved Hide resolved
@s-ben
Copy link
Contributor Author

s-ben commented Dec 18, 2018

@lukebp, nice suggestions. You may want to double check my rewordings for accuracy, but I think we're almost there. Also, while I have your eyeballs, can you check my attempted definition of Signature and Receipt for the comments.journal file in the pi data page? Issue: #697

@xaur, left a comment on that politeiagui Issue regarding the modal copy,
decred/politeiagui#947

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few in-line comments, but also one general comment.

This PR adds some new hyperlinks pointing to internal docs pages, and the link text is not capitalised. I think we might want to capitalise them so the formatting of the link text matches the formatting of the page title. I gathered a list as I was going through the PR:

politeia.md
	[introduction to Decred governance]
	[proposal guidelines]
	[example proposals]
	[navigating politeia data]

example-proposals.md
	[proposal guidelines]

proposal-guidelines.md
	[example proposals]

Thoughts about that?

docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia.md Outdated Show resolved Hide resolved
docs/governance/politeia/example-proposals.md Show resolved Hide resolved
docs/governance/politeia/example-proposals.md Outdated Show resolved Hide resolved
docs/governance/politeia/proposal-guidelines.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@lukebp
Copy link
Member

lukebp commented Dec 19, 2018

@s-ben the text that you updated to address my issues LGTM.

@s-ben
Copy link
Contributor Author

s-ben commented Dec 19, 2018

@jholdstock , good catches. Have implemented your suggestions.

@jholdstock
Copy link
Member

Two comments outstanding above. Otherwise everything is looking good to me.

@s-ben
Copy link
Contributor Author

s-ben commented Dec 20, 2018

@jholdstock comments addressed. PR moon?

@RichardRed0x
Copy link
Member

Looks good to me generally, I like the tips for creating a successful proposal.
I see the marketing example has ugly horizontal scroll bars, I recall trying to deal with something similar for the modal window display of that. Doesn't bother me too much personally.

@s-ben
Copy link
Contributor Author

s-ben commented Dec 21, 2018

@RichardRed0x yeah @jholdstock was noticing the ugly too (his comment below for reference). I think it's the best we can do for now, but there's an open issue to address it.

I don't think we should be putting the proposal example text in codeblocks on this page. They aren't ideal for prose as they use the monospace font and they don't format nicely on small screens/windows.

That being said, we don't have many alternatives. The "correct" approach is probably to use blockquotes, but this would make the text green as a result of #566. I just tried this out and it doesn't look right.

Lets keep the codeblocks for now and I will open a new issue for this: #759

@jholdstock jholdstock merged commit b60350d into decred:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants