Rework mempool page #982
Merged
Rework mempool page #982
+527
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! What other sites need fixing? Also the mobile version is prettyt broken. |
|
@lte13 The
Are you talking about this PR in particular? Screenshots and suggestions are certainly appreciated. |
|
The "HODL" watermark can certainly go. It was a gag that was so subtle it didn't really bug anyone. But still, it was a gag that ran it's course. :) Some ideas for the votes table on mobile:
|
|
Rebased and tweaked vote table for mobile view.
|
|
@chappjc I just saw that you were thinking of hiding "Total DCR", and I hid the "Size" column instead. I left "Validator ID" because it might help explain why there are more than 5 votes on the best block, which is common (different agenda choices from different VSP). |
|
Switched hidden mobile votes table column from Size to Total DCR. Removed WIP. |
|
Thanks. Size is strangely useful because it gives you a hint if it is a regular solo, pool, or weird split ticket being spent. |
|
Using the "https://getbootstrap.com/docs/4.2/content/tables/#responsive-tables" utility class will make the table horizontally scrollable when screen real estate is tight. Not ideal, but probably the least bad solution. Best to scope it to the breakpoint where its actually needed. |
gozart1
reviewed
Feb 7, 2019
gozart1
reviewed
Feb 7, 2019
Adjustments to the mempool page layout. See decred#451. Incorporates client-side mempool from decred#961 for live updates. Moves `likelyMineable` totals and counts to their own explorer type. Creates a `mempoolDump` template to pass mempool stats to stimulus via data attributes.
Hides size and time columns on the votes table at < 576 px screen widths. A couple other column headers are abbreviated and given a tooltip at the same breakpoint. Better dark mode bg color for the transaction details panel. Dropped 'Best Block' boolean column, instead just adding indicating the best block in the 'Voting On' column. Fixes the exchange rate info on the homepage, which was not quite adjusted to the new layout.
|
I did use I don't have a strong opinion either way. |
Prepared CSS for wider application. Eliminated mempool.scss.
chappjc
approved these changes
Feb 7, 2019
gozart1
approved these changes
Feb 7, 2019
buck54321
added a commit
to buck54321/dcrdata
that referenced
this pull request
Feb 18, 2019
Restyles /block page. Compare to prototype from decred#451. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from decred#982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messaages are calculated so that each `newblock.confirmations` controller target can have a custom text.
buck54321
added a commit
to buck54321/dcrdata
that referenced
this pull request
Feb 18, 2019
Restyles /block page. Compare to prototype from decred#451. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from decred#982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messaages are calculated so that each `newblock.confirmations` controller target can have a custom text.
buck54321
added a commit
to buck54321/dcrdata
that referenced
this pull request
Feb 18, 2019
Restyles /block page. Compare to prototype from decred#451. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from decred#982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messaages are calculated so that each `newblock.confirmations` controller target can have a custom text.
Merged
buck54321
added a commit
to buck54321/dcrdata
that referenced
this pull request
Feb 20, 2019
Restyles /block page. Compare to prototype from decred#451. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from decred#982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messaages are calculated so that each `newblock.confirmations` controller target can have a custom text.
chappjc
pushed a commit
that referenced
this pull request
Feb 22, 2019
This restyles /block page. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from #982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messages are calculated so that each `newblock.confirmations` controller target can have a custom text. * tweak hash box. reorder table. fix and filter rate conversion The hash box is lightened and a little vertical padding is added. A couple of issues in the DCR->USD conversion are addressed. Now, it will only show the conversion for blocks within that last hour, since older figure should be converted using historical data. * adjust padding. truncate less on count labels. simplify block hash * lower line height where text wraps
mkingori
pushed a commit
to mkingori/dcrdata
that referenced
this pull request
Apr 9, 2020
This restyles /block page. Comparisons with prototype: Instead of the coinbase reward field, which is listed below, I've included the size field on the left, and added the fees field on the details pane. I've removed the "Block Details" header and stole the description for the right pane, as "Block Hashes" was not very accurate. This left the page a little out of sync with the recently worked mempool page, so I'm certainly open to adding it back if we can find the right description. Where the prototype had a single table in which the transaction type was selectable, the separate tables are left here and the table style from decred#982 has been applied. This keeps everything no-js friendly. Adds a couple of methods for custom time display to `explorertypes.TimeDef`. The types are not mirrored in `dbtypes.TimeDef`. Tweaks the way live confirmation messages are calculated so that each `newblock.confirmations` controller target can have a custom text. * tweak hash box. reorder table. fix and filter rate conversion The hash box is lightened and a little vertical padding is added. A couple of issues in the DCR->USD conversion are addressed. Now, it will only show the conversion for blocks within that last hour, since older figure should be converted using historical data. * adjust padding. truncate less on count labels. simplify block hash * lower line height where text wraps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to the mempool page layout. Compare with current master and this mockup from #451.
Incorporates client-side mempool from #961 for live updates.
Moves
likelyMineabletotals and counts to their own explorer type. Creates amempoolDumptemplate to pass mempool stats to stimulus via data attributes.WIP until at least the following are approved/discussed.
Vote table columns. More or less? Compare to mockup. We also have the vote icons now that might come in handy. Tables get a little tight at low screen width. With the current set of columns, I needed to set the vote table to allow scrolling at the smallest widths.
I have left the entire hash in place, though that has some unfortunate consequences at smaller widths.
This PR removes "HODL" watermark. I think its an improvement. Other might not.
I did not use the blue color from the mockup for sections headers, as that color already designates links. Should we use it anyway, or a different color, or leave them.