multi: Remove non-root module replacements. #1599
Merged
+583
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
multi_remove_module_overrides
branch
2 times, most recently
from
3c6c6c3 to
6475eda
Compare
jrick
approved these changes
Feb 8, 2019
This modifies all of the modules, with the exception of the root module, to remove all replacement directives from their go.mod files and update the requirements and module sums accordingly. While it is nice to be able to build and test directly from each module directory and have it pull in the latest untagged changes when developing, having all of the overrides in each module makes it infeasible to use the module tools to help maintain the modules and thus makes it quite difficult to ensure they are all independently accurate for external consumers. By maintaining all of the overrides in the root module and invoking all builds and tests from it, the overrides will apply to ensure the latest code is being built and tested. This also modifies the tests script used with in CI to run all of the tests from the root module accordingly.
davecgh
force-pushed
the
multi_remove_module_overrides
branch
from
6475eda to
e052b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies all of the modules, with the exception of the root module, to remove all replacement directives from their
go.modfiles files and update the requirements and module sums accordingly.While it is nice to be able to build and test directly from each module directory and have it pull in the latest untagged changes when developing, having all of the overrides in each module makes it infeasible to use the module tools to help maintain the modules and thus makes it quite difficult to ensure they are all independently accurate for external consumers.
By maintaining all of the overrides in the root module and invoking all builds and tests from it, the overrides will apply to ensure the latest code is being built and tested.
This also modifies the tests script used with in CI to run all of the tests from the root module accordingly.