Skip to content

refactor(io): move io constants to common/io #9700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jan 21, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • move io constants to common/io, so crates can re-use them
  • BlockCompactThresholds -> BlockThresholds

Closes #issue

@vercel
Copy link

vercel bot commented Jan 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 21, 2023 at 6:12AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 21, 2023
@BohuTANG BohuTANG marked this pull request as ready for review January 21, 2023 06:15
@BohuTANG
Copy link
Member Author

Refactoring, let's merge.

@BohuTANG BohuTANG merged commit 5ef3367 into databendlabs:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant