Skip to content

feat(optimizer): Improve cardinality estimation for join based on histogram #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2023
Merged

feat(optimizer): Improve cardinality estimation for join based on histogram #9594

merged 7 commits into from
Jan 16, 2023
+571 −309

Conversation

xudong963
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #9409

@vercel
Copy link

vercel bot commented Jan 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:51AM (UTC)

@xudong963 xudong963 marked this pull request as draft January 13, 2023 11:14
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 13, 2023
@xudong963
implement join card by ndv

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
e4f970e
@xudong963
update

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
75eb1a5
@xudong963
feat(optimizer): Improve cardinality estimation for join based on his…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
dba544f 
…togram
@xudong963 xudong963 marked this pull request as ready for review January 13, 2023 14:58
@xudong963
update tests

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
bfa098b
@xudong963
fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
fc7caf7
@BohuTANG
Copy link
Member

It seems test_sqllogic_ydb_cluster_linux always timeout. Try to reduce the parallel threads?

@Xuanwo
Copy link
Member

Xuanwo commented Jan 14, 2023

It seems test_sqllogic_ydb_cluster_linux always timeout. Try to reduce the parallel threads?

Some thing must be buggy. We have a 30m timeout, and test_sqllogic_ydb_standalone_linux finished in 11m, test_sqllogic_ydb_cluster_linux should not be timeout.

@xudong963
Copy link
Contributor Author

It seems test_sqllogic_ydb_cluster_linux always timeout. Try to reduce the parallel threads?

I'm debuging it in #9595

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2023

update

✅ Branch has been successfully updated

@mergify
Merge branch 'main' into join_cardi

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8110312
@xudong963
Copy link
Contributor Author

It seems test_sqllogic_ydb_cluster_linux always timeout. Try to reduce the parallel threads?

I'm debuging it in #9595

I just enable --debug arg, and it seems ci becomes smooth 🤣

image

Continuous observation is required

@BohuTANG
Copy link
Member

#9615 fixed the timeout of logictest.

@xudong963
Copy link
Contributor Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2023

update

✅ Branch has been successfully updated

@mergify
Merge branch 'main' into join_cardi

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d697fdb
leiysky
leiysky approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@xudong963 xudong963 merged commit 668c0e4 into databendlabs:main Jan 16, 2023
@xudong963 xudong963 deleted the join_cardi branch January 16, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky

@andylokandy andylokandy

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve cardinality estimation for join operator
4 participants
@xudong963 @BohuTANG @Xuanwo @leiysky