Skip to content

feat(query): add information_schema for sharding-jdbc #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2023
Merged

feat(query): add information_schema for sharding-jdbc #9583

merged 4 commits into from
Jan 14, 2023
+177 −1

Conversation

yufan022
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Closes #9582

@vercel
Copy link

vercel bot commented Jan 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 13, 2023 at 6:59PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

This pull request's title is not fulfill the requirements. @yufan022 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@yufan022 yufan022 changed the title add information_schema for sharding-jdbc feat(query): add information_schema for sharding-jdbc Jan 12, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 12, 2023
@BohuTANG BohuTANG requested a review from TCeason January 12, 2023 15:03
TCeason
TCeason approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please make ci pass.

@yufan022
Merge branch 'datafuselabs:main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a883d51
@yufan022
Merge branch 'datafuselabs:main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4cf1a4d
@yufan022
add sql logic test for sharding-jdbc compatible
e015d13
@BohuTANG BohuTANG merged commit ee0569c into databendlabs:main Jan 14, 2023
@yufan022 yufan022 mentioned this pull request Feb 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo

@TCeason TCeason

@BohuTANG BohuTANG

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Make databend compatible with Sharding-JDBC
4 participants
@yufan022 @BohuTANG @Xuanwo @TCeason