Skip to content

feat(query): support insert with placeholder. #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 12, 2023
Merged

feat(query): support insert with placeholder. #9575

merged 8 commits into from
Jan 12, 2023
+256 −20

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jan 12, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #9546

cc @ZhiHanZ

@vercel
Copy link

vercel bot commented Jan 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 12, 2023 at 10:35AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

This pull request's title is not fulfill the requirements. @youngsofun please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@youngsofun youngsofun requested a review from everpcpc January 12, 2023 05:09
@youngsofun youngsofun changed the title feature(query): support insert with placeholder. feat(query): support insert with placeholder. Jan 12, 2023
@youngsofun youngsofun requested a review from sundy-li January 12, 2023 05:10
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 12, 2023
@youngsofun youngsofun requested a review from ariesdevil January 12, 2023 06:08
@youngsofun youngsofun force-pushed the fmt branch 2 times, most recently from fdaf309 to 22f0205 Compare January 12, 2023 09:35
@youngsofun
Copy link
Member Author

have no idea why test_cast fail in CI, seems not related to this pr and it can pass on my mac.
https://github.com/datafuselabs/databend/actions/runs/3900959123/jobs/6662232778

@youngsofun youngsofun mentioned this pull request Jan 12, 2023
Closed
@youngsofun
Copy link
Member Author

waiting for #9578

@BohuTANG
Copy link
Member

@mergify update

@BohuTANG
Copy link
Member

waiting for #9578

Merged.

@mergify
Merge branch 'main' into fmt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
337e06b
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit 4939471 into databendlabs:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG

@sundy-li sundy-li

@everpcpc everpcpc

@ariesdevil ariesdevil

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support placeholder on databend http api
5 participants
@youngsofun @BohuTANG @everpcpc @sundy-li @ariesdevil