Skip to content

fix(expr): check_date() and to_string(boolean) may panic #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix(expr): check_date() and to_string(boolean) may panic #9561

merged 1 commit into from
Jan 12, 2023

Conversation

andylokandy
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 12, 2023 at 8:03AM (UTC)

@andylokandy andylokandy requested a review from sundy-li January 10, 2023 08:46
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jan 10, 2023
@BohuTANG
Copy link
Member

Some tests need to be fixed:

[SQL] explain select t.number from numbers(1) as t, numbers(1) as t1 where t.number > 1 and 1 < t1.number
[Diff] (-excepted|+actual)
    HashJoin
    ├── join type: CROSS
    ├── build keys: []
    ├── probe keys: []
    ├── filters: []
    ├── estimated rows: 0.11
    ├── Filter(Build)
    │   ├── filters: [lt(1_u8, t1.number (#1))]
    │   ├── estimated rows: 0.33
    │   └── TableScan
    │       ├── table: default.system.numbers
    │       ├── read rows: 1
    │       ├── read bytes: 8
    │       ├── partitions total: 1
    │       ├── partitions scanned: 1
-   │       ├── push downs: [filters: [lt(1_u64, number)], limit: NONE]
+   │       ├── push downs: [filters: [lt(1, number)], limit: NONE]
    │       └── estimated rows: 1.00
    └── Filter(Probe)

@andylokandy andylokandy changed the title fix(expr): check_date() may panic fix(expr): check_date() and to_string(boolean) may panic Jan 11, 2023
@BohuTANG BohuTANG merged commit 686066f into databendlabs:main Jan 12, 2023
BohuTANG added a commit that referenced this pull request Jan 12, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix breaking test since #9561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-expression pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants