refactor: Refine on_error mode #9473
Merged
+427
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
ariesdevil
force-pushed
the
refine-on-error
branch
5 times, most recently
from
1c96e16 to
0f50270
Compare
ariesdevil
force-pushed
the
refine-on-error
branch
from
0f50270 to
566fa11
Compare
drmingdrmer
reviewed
Jan 13, 2023
There was a problem hiding this comment.
Increase the VER:
https://github.com/datafuselabs/databend/blob/78d127257519bea475ad1361ee0359da764a443b/src/meta/proto-conv/src/util.rs#L80-L83
Add another test file to ensure coding/decoding works as expected. Similar to this:
https://github.com/datafuselabs/fuse-query/blob/78d127257519bea475ad1361ee0359da764a443b/src/meta/proto-conv/tests/it/v024_table_meta.rs
BohuTANG
reviewed
Jan 14, 2023
ariesdevil
force-pushed
the
refine-on-error
branch
from
566fa11 to
c6b2906
Compare
sundy-li
reviewed
Jan 15, 2023
src/query/pipeline/sources/src/processors/sources/input_formats/impls/input_format_tsv.rs
Show resolved
Hide resolved
ariesdevil
force-pushed
the
refine-on-error
branch
from
2829392 to
3a4d9ee
Compare
BohuTANG
reviewed
Jan 15, 2023
sundy-li
approved these changes
Jan 16, 2023
drmingdrmer
reviewed
Jan 16, 2023
youngsofun
approved these changes
Jan 16, 2023
drmingdrmer
reviewed
Jan 16, 2023
ariesdevil
force-pushed
the
refine-on-error
branch
from
dfdf67f to
67b2e02
Compare
drmingdrmer
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Refine
on_errormodeabort_nmode.NOTE:
In future refactoring, we'll return statistics to the user. These changes are related to big refactoring.
Closes #issue