Skip to content

fix(hive): may get wrong datablocks if not sorted by output schema #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023
Merged

fix(hive): may get wrong datablocks if not sorted by output schema #9470

merged 4 commits into from
Jan 20, 2023

Conversation

FANNG1
Copy link

@FANNG1 FANNG1 commented Jan 5, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Closes #issue

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 20, 2023 at 2:41PM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jan 5, 2023
@FANNG1
Copy link
Author

FANNG1 commented Jan 5, 2023

cc @sundy-li @RinChanNOWWW

Copy link
Contributor

@RinChanNOWWW RinChanNOWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And in do_deserialize, self.remain_reader seems always be Some(_), we can add Err(ErrorCode::Internal("It's a bug. No remain reader")) there.

@FANNG1
Copy link
Author

FANNG1 commented Jan 5, 2023

LGTM. And in do_deserialize, self.remain_reader seems always be Some(_), we can add Err(ErrorCode::Internal("It's a bug. No remain reader")) there.

will update the patch after test on our cluster.

@sundy-li sundy-li marked this pull request as draft January 5, 2023 16:06
@sundy-li
Copy link
Member

sundy-li commented Jan 6, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2023

update

❌ Base branch update has failed

merge conflict between base and head
err-code: FB3E5

@FANNG1
Copy link
Author

FANNG1 commented Jan 19, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@FANNG1
Copy link
Author

FANNG1 commented Jan 19, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

update

✅ Branch has been successfully updated

@FANNG1
Copy link
Author

FANNG1 commented Jan 19, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/release.yml without workflows permission
err-code: 6B0C9

@FANNG1
Copy link
Author

FANNG1 commented Jan 20, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/dev-linux.yml without workflows permission
err-code: A810E

@FANNG1
Copy link
Author

FANNG1 commented Jan 20, 2023

OHH, always see this error:

Error: '/Users/runner/work/_actions/_temp_debe1b19-4d5e-446b-9f69-8babf821fe4c/6dcc06e3-c8cb-4966-b1d0-bde205c00812.tar.gz' contains '0' directories

@RinChanNOWWW
Copy link
Contributor

RinChanNOWWW commented Jan 20, 2023

How about merging the latest main and repon this PR.

@FANNG1 FANNG1 marked this pull request as ready for review January 20, 2023 14:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify mergify bot merged commit 98abfdf into databendlabs:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants