Skip to content

refactor(storage/cache): add to_bytes and from_bytes for CachedObject #9439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jan 2, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add to_bytes and from_bytes for CachedObject, and make the T provider define the serialize and deserialize.

Closes #issue

@vercel
Copy link

vercel bot commented Jan 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 2, 2023 at 8:09AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 2, 2023
@BohuTANG BohuTANG marked this pull request as ready for review January 2, 2023 08:09
@BohuTANG BohuTANG requested a review from dantengsky January 2, 2023 08:10
@BohuTANG
Copy link
Member Author

BohuTANG commented Jan 2, 2023

Let's merge and continue try to replacing.

@BohuTANG BohuTANG merged commit c79f9e8 into databendlabs:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant