feat: migrate hash func to func-v2 #9402
Merged
+1,505
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sundy-li
reviewed
Dec 29, 2022
sundy-li
reviewed
Dec 29, 2022
TCeason
force-pushed
the
ISSUE-9385
branch
2 times, most recently
from
c58cadd to
1c340cb
Compare
|
In function v1, DFHash has these: impl<'a> DFHash for &'a VariantValue How to convert it into function-v2? Need help cc @sundy-li @andylokandy |
TCeason
changed the title
mergify
bot
added
the
pr-feature
sundy-li
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
migrate hash func to func-v2
Closes #issue