Skip to content

chore(sqllogictests): fix column types of MySQLClient #11718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2023
Merged

chore(sqllogictests): fix column types of MySQLClient #11718

merged 3 commits into from
Jun 12, 2023
+4 −1

Conversation

jonahgao
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

The length of column types should not be equal to the length of rows.

@vercel
Copy link

vercel bot commented Jun 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 12, 2023 2:38am

@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2023

This pull request's title is not fulfill the requirements. @byteink please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@jonahgao jonahgao changed the title sqllogictests: fix column types of MySQLClient fix(sqllogictests): fix column types of MySQLClient Jun 11, 2023
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 11, 2023
@jonahgao jonahgao changed the title fix(sqllogictests): fix column types of MySQLClient chore(sqllogictests): fix column types of MySQLClient Jun 11, 2023
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 11, 2023
@BohuTANG BohuTANG requested a review from xudong963 June 12, 2023 02:05
xudong963
xudong963 reviewed Jun 12, 2023
View reviewed changes
@jonahgao @xudong963
Update tests/sqllogictests/src/client/mysql_client.rs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d3ff42c 
Co-authored-by: xudong.w <wxd963996380@gmail.com>
@BohuTANG
Copy link
Member

Thanks for your contritution 👍 @byteink

@BohuTANG BohuTANG merged commit e42d416 into databendlabs:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonahgao @BohuTANG @xudong963