Skip to content

feat: select from stage support NDJson. #11701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2023
Merged

feat: select from stage support NDJson. #11701

merged 3 commits into from
Jun 9, 2023
+148 −56

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jun 8, 2023 •
edited by b41sh
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

select $1 from @my_stage
select $1:a from @my_stage

copy into my_table from (select $1 from @my_stage t)

note that, when use select for NDJson, only $1 is allowed, which stands for the whole line and has the type variant.
while copy into my_table from @my_stage is matched by name (of top level fields) instead.

cc @wubx NDJson is easier to impl, so I start with it instead of CSV first

Closes #issue

@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 2:15pm

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 8, 2023
@youngsofun youngsofun requested a review from b41sh June 8, 2023 05:36
@youngsofun
Copy link
Member Author

https://github.com/datafuselabs/databend/actions/runs/5207738209/jobs/9395579546?pr=11701

💥 maturin failed
  Caused by: Failed to parse Cargo.toml into python metadata
  Caused by: Rust version used in Cargo.toml is not a valid python version: Version `1.1.56-draft` doesn't match PEP 440 rules. Note that rust uses [SemVer](https://semver.org/) while python uses [PEP 440](https://peps.python.org/pep-0440/), which have e.g. some differences when declaring prereleases.
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
Error: The process '/usr/bin/docker' failed with exit code 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

@youngsofun youngsofun requested a review from sundy-li June 8, 2023 05:38
@youngsofun youngsofun marked this pull request as draft June 8, 2023 06:28
@youngsofun youngsofun marked this pull request as ready for review June 8, 2023 06:34
@youngsofun
feat: select from stage support ndjson.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
acfbf61
@BohuTANG BohuTANG merged commit 252760b into databendlabs:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh

@sundy-li sundy-li

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youngsofun @b41sh @sundy-li @BohuTANG