Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Support ::ng-deep as an alternative to /deep/ #454

Closed
@zoechi

Description

@zoechi

Angular will need some replacement
sass/dart-sass#154

Activity

changed the title [-]/deep/ is not supported by dart-sass[/-] [+]/deep/ is not supported by dart-sass anymore[/+] on Jun 12, 2017
matanlurey

matanlurey commented on Jun 15, 2017

@matanlurey
Contributor

We have a number of ideas, but nothing I'm able to publish yet. Will update soon.

added this to the V4 Alpha milestone on Jun 15, 2017
zoechi

zoechi commented on Jun 15, 2017

@zoechi
Author

That's what I wanted to hear, that it's on your radar. No need to provide details right now.

changed the title [-]/deep/ is not supported by dart-sass anymore[/-] [+]Support ::ng-deep as an alternative to /deep/[/+] on Jun 16, 2017
matanlurey

matanlurey commented on Jun 16, 2017

@matanlurey
Contributor

We've decided to deprecate /deep/ and >>>, and support ::ng-deep as a drop-in.

Here is our internal test case for this feature:

  test('should handle ::ng-deep', () {
    var css = '::ng-deep y {}';
    shimAndExpect(css, 'y {}');
    css = 'x ::ng-deep y {}';
    shimAndExpect(css, 'x.$content y {}');
    css = ':host > ::ng-deep .x {}';
    shimAndExpect(css, '.$host > .x {}');
    css = ':host ::ng-deep > .x {}';
    shimAndExpect(css, '.$host > .x {}');
    css = ':host > ::ng-deep > .x {}';
    shimAndExpect(css, '.$host > > .x {}');
  });

We've gotten confirmation this will be supported (parsable) in all major SASS tooling.

AngularDart 4.x.x will be the last major release to support either /deep/ or >>> (both, including ::ng-deep, will be available in 4.0). As a result, native shadow DOM will also be deprecated (but not immediately removed), since there is no way after Chrome's /deep/ deprecation lands, and we don't have another story (yet).

NOTE: We will back-port and release 3.2.0 to unblock our users, but other packages (like angular_components) will need to be updated too in order to take advantage of this fully.

16 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @matanlurey@zoechi@alorenzen@leonsenft

      Issue actions

        Support ::ng-deep as an alternative to /deep/ · Issue #454 · angulardart/angular