Skip to content

Cleanup metrics #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Cleanup metrics #3776

merged 1 commit into from
Mar 26, 2020

Conversation

miekg
Copy link
Member

@miekg miekg commented Mar 26, 2020

Cleanup a variety of metric issues.

  • Eliminate department of redundancy "count_total" naming.
  • Use the plural of the unit when appropriate. (ex, "requests")
  • Remove label names from metric names where appropriate. (ex, "rcode")
  • Simplify request metrics by consolidating type label in to the base
    request counter.
  • Re-generate man pages.

miek: this is a copy of #3671 with the manual pages changes backed out
and then rebased on top of master. This required some new git-foo from
myself so YMMV with what we've ended up with.

Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ
Copy link
Collaborator

SuperQ commented Mar 26, 2020

Oh, Sure, I could just rebase the other PR if you want.

@miekg
Copy link
Member Author

miekg commented Mar 26, 2020

this seems to have done the trick - history is also preserved. I'll merge.

@miekg miekg merged commit 19cfa29 into master Mar 26, 2020
@miekg miekg deleted the remove-man branch March 26, 2020 08:17
@miekg miekg mentioned this pull request Mar 26, 2020
nyodas pushed a commit to DataDog/coredns that referenced this pull request Oct 26, 2020

Verified

This commit was signed with the committer’s verified signature.
nyodas Bob
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.

Signed-off-by: Ben Kochie <superq@gmail.com>

Co-authored-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants