Skip to content

Codesandbox define API request need redirect #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xPoe opened this issue Mar 28, 2020 · 6 comments
Closed

Codesandbox define API request need redirect #3769

0xPoe opened this issue Mar 28, 2020 · 6 comments

Comments

@0xPoe
Copy link

0xPoe commented Mar 28, 2020

🐛 bug report

Codesandbox define API need redirect.

Description of the problem

ant-design/ant-design#22636

How has this issue affected you? What are you trying to accomplish?

ant-design/ant-design#22636

Link to sandbox: link (optional)

https://codesandbox.io/s/define-api-post-request-qzlp7nw34q?from-embed

Your Environment

Software Name/Version
Сodesandbox 1.1.13
Browser chrome Version 80.0.3987.149 (Official Build) (64-bit)
Operating System mac os 10.15.3
@0xPoe 0xPoe changed the title Codesandbox define API need redirect Codesandbox define API request need redirect Mar 28, 2020
@garethx
Copy link
Contributor

garethx commented Mar 31, 2020

I'm not clear from the linked issue what it is you're requesting. You can already get the ID of a generated sandbox which you can use to create a redirect, see https://codesandbox.io/docs/importing#define-without-render

@karlhorky
Copy link

karlhorky commented Mar 31, 2020

I'm running into this too (just noticed it since a few days). This causes a "redirect" link on iframes using a src with a /define URL. Up until a few days / weeks ago, this was just showing the content of the target page of the redirect.

Sandbox: https://codesandbox.io/s/define-api-get-request-00f4f

Screen Shot 2020-03-31 at 16 21 31


This causes solutions using things similar to gatsby-remark-embedded-codesandbox to fail. See:

@CompuIves
Copy link
Member

Looking into this now...

@CompuIves
Copy link
Member

It should work as expected now again, I'm sorry for the inconvenience! This was a regression due to a recent CORS change.

@karlhorky
Copy link

karlhorky commented Mar 31, 2020

Wow so fast Ives! 🚀💯 Looks good, back to normal! :)

@Rustin-Liu is it back to normal for you too? If so, I guess this can be closed. Looks like at least your demo links is working...

@0xPoe
Copy link
Author

0xPoe commented Mar 31, 2020

@karlhorky @CompuIves @garethx Thank for your supporting, it's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants