This repository was archived by the owner on Nov 12, 2024. It is now read-only.
Update show details to Compose #583
Merged
+2,338
−2,756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/show-details-compose
branch
from
f559766 to
fd1dc63
Compare
Removed nearly all of the view implementation
chrisbanes
force-pushed
the
cb/show-details-compose
branch
from
fd1dc63 to
27b0862
Compare
Also moved back to using setContent now that it is lifecycle aware
Until I work out how to host fragments inside Compose
We now use a intermediary Channel to break the direct dependency on the ViewModel, allowing us to remove a potential leak.
|
Ready for review. Demo video: https://youtu.be/t-F4Q052QoY |
- Tidied up a lot of the TypedArray fetching and conversion to Compose types to new ext funs. - Read shape appearances from MDC theme. - Now properly read dimension units from TypedArray, for TextUnit and CornerSize. - Add new `useTextColors` option, since using hardcoded colors in TextStyles breaks emphasis. - Extracted reading logic to new `generateMaterialThemeFromContext` effect.
objcode
approved these changes
Apr 17, 2020
| var canExpand by stateFor(text) { true } | ||
|
|
||
| Box(modifier = Modifier.ripple(bounded = true, enabled = canExpand)) { | ||
| var expanded by state { false } |
There was a problem hiding this comment.
Suggest hoisting this as it seems reasonable callers may want to control the state.
The icons are nearly always designed with a light background in mind. Therefore we only tint them using the content color if we're in a dark theme.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.