This repository was archived by the owner on Nov 12, 2024. It is now read-only.
- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 889
Converting episode details to use Jetpack Compose #544
Merged
+2,111
−637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38241d2
to
4bcc34b
Compare
ui-episodedetails-compose/src/main/java/app/tivi/episodedetails/EpisodeDetails.kt
Outdated
Show resolved
Hide resolved
Episode details is now completely empty (shows dummy text) but it works.
4bcc34b
to
c65c8e3
Compare
30e8e22
to
514be7d
Compare
514be7d
to
51fef51
Compare
Allows us to automatically dispose of the composition once the lifecycle has been destroyed. Very useful for fragments, with viewLifecycleOwner
Some things are broken: - Swipe to dismiss expanding circle - Center alignment of info panes
fadb98f
to
16bff65
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.