luminous: os/bluestore/BlueFS: compact log even when sync_metadata sees no work #34876
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifed01
changed the title
|
@ifed01 I tried to cherry-pick this and there was a conflict in |
It's possible that when sync_metadata() is called there won't be any new log data to flush because it was already flushed for other reasons (e.g., because fsync was called). However, the log may still be large and in need of compaction. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit dfe5f05) Conflicts: src/os/bluestore/BlueFS.cc Some pending release stuff that is now absent at both Luminous and master.
ifed01
force-pushed
the
wip-ifed-fix-no_compact_bluefs
branch
from
0975efb to
5eeb70b
Compare
@smithfarm - my bad, there was a conflict. Fixed. |
smithfarm
approved these changes
May 5, 2020
xiexingguo
approved these changes
May 7, 2020
neha-ojha
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #17354 to luminous
It's possible that when sync_metadata() is called there won't be any new
log data to flush because it was already flushed for other reasons (e.g.,
because fsync was called). However, the log may still be large and in
need of compaction.
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit dfe5f05)
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox