Glide compiler for AndroidX project partially supports `androidx.annotation` namespace #3185

KevinLeigh · 2018-07-05T13:28:26Z

Currently Glide compiler is partially supporting androidx.annotation namespace, currently the AndroidX project I am building is failing because Glide compiler is still using android.support.annotation.CheckResult and android.support.annotation.NonNull rather than its successors androidx.annotation.NonNull & androidx.annotation.CheckResult.

I have tried with both versions 4.7.1 & 4.8.0-SNAPSHOT

It would be great if the AndroidX annotation namespace is completely supported rather than partially supported.

Basically any occurrence of android.support.annotation should change to androidx.annotation

The text was updated successfully, but these errors were encountered:

KevinLeigh · 2018-07-05T14:19:11Z

For now I temporarily added the below so that there is no longer a compilation error:

// TODO remove temporary fix for Glide compiler issue
// Temporary fix begin
implementation 'com.android.support:support-annotations:27.1.1'
annotationProcessor 'com.android.support:support-annotations:27.1.1'
// Temporary fix end

Rajeshr34 · 2018-07-06T03:34:56Z

Temporary fix not working for me with android databinding enabled.

KevinLeigh · 2018-07-06T08:11:47Z

@Rajeshr34 Hey there, are you using AndroidX? Please post your error as well

Rajeshr34 · 2018-07-06T09:50:44Z

@KevinLeigh Same annotation errors.... also tried to make change and build but its not worked for me. is there any solution for this?

KevinLeigh · 2018-07-06T10:29:22Z

@Rajeshr34
It works fine on my side, please see below the project setup that I am using.

I am using Glide 4.8.0-SNAPSHOT for both annotation processor library and core library. I am using Android Studio IDE 3.3 Canary build Version 2 with Gradle version 4.8, as well as Gradle build tools 3.3.0-alpha02. I would not recommend this setup for a project that is in production that should use only stable versions of libraries. This current setup is only for trying out certain features that are not yet available in stable releases.

KevinLeigh · 2018-07-06T10:56:54Z

@Rajeshr34

Another thing is you should always clean rebuild your project correctly when making major updates.

The reason the temporary fix should work is because android.support.annotation does not exist when you update to use androidx.annotation, and Glide compiler is currently using both namespaces to generate classes. So importing older namespace android.support.annotation will include the missing namespace that no longer exists when using androidx.annotation, so your project should now have both namespaces.

Rajeshr34 · 2018-07-06T11:03:01Z

@KevinLeigh Thank You. its working now

implementation 'com.github.bumptech.glide:glide:4.8.0-SNAPSHOT'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0-SNAPSHOT'
implementation 'com.github.bumptech.glide:okhttp3-integration:4.8.0-SNAPSHOT@aar'
implementation "com.android.support:support-annotations:28.0.0-alpha3"
annotationProcessor 'com.android.support:support-annotations:28.0.0-alpha3'

KevinLeigh · 2018-07-06T11:05:11Z

@Rajeshr34 All good, glad it is working on your side.

kerjani · 2018-07-10T15:15:27Z

Hi,
The solution sounds good, but when will be the 4.8.0-SNAPSHOT version available?

Rajeshr34 · 2018-07-10T17:16:19Z

@kerjani 4.8.0-SNAPSHOT is out

allprojects {
    repositories {
        google()
        jcenter()
        
        /*glide snapshot repo*/
        maven {
            name 'glide-snapshot'
            url 'http://oss.sonatype.org/content/repositories/snapshots'
        }

        //Image Gallery
        maven { url "https://jitpack.io" }
    }
}

mufumbo · 2018-07-12T23:54:41Z

@Rajeshr34 is it working for you? here it's still using damn android.support.annotation package rather than android.xannotation

Shusshu · 2018-07-26T07:29:45Z

4.8.0-SNAPSHOT works for me

mice777 · 2018-08-15T12:27:37Z

I solved this by normally using stable version 4.7.1, and added files Nullable.java and CheckResult.java into my project from Android SDK sources (into correct path android\support\annotation). Then Glide finds its annotation classed, and it works, while my app uses AndroidX.

friederikewild · 2018-08-18T22:15:44Z

I can confirm using Glide version 4.8.0 works for me in combination with androidX.
Make sure to activate android.enableJetifier=true in your gradle.properties. In addition, I had to clean the project before I could finally get rid of various build errors and get it to work.
Found the tips here #3184 (comment) and confirmation on #3229 (comment)

HimanshuNarang · 2018-09-13T09:47:09Z

In build.gradle
api 'com.github.bumptech.glide:glide:4.8.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0'

In gradle.properties
android.enableJetifier=true
android.useAndroidX=true

But still having compile time error for
Glide.with((androidx.fragment.app.Fragment) fragmentInstance);
Cannot resolve method with androidx.fragment.app.Fragment

CnPeng · 2018-09-26T12:36:29Z

@friederikewild
In build.gradle
implementation 'com.github.bumptech.glide:glide:4.8.0' annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0'
In gradle.properties
android.enableJetifier=true android.useAndroidX=true
but still can't convert "android.support.annotation.CheckResult" and "android.support.annotation.NonNull"

i have to add "com.android.support:support-annotations:28.0.0-alpha3" in gradle，like this
implementation 'com.github.bumptech.glide:glide:4.8.0' annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0' implementation "com.android.support:support-annotations:28.0.0-alpha3" annotationProcessor 'com.android.support:support-annotations:28.0.0-alpha3'
after add "com.android.support:support-annotations:28.0.0-alpha3" , i can complier and install

PiN73 · 2018-10-02T16:01:08Z

implementation 'com.github.bumptech.glide:glide:4.8.0'
annotationProcessor 'androidx.annotation:annotation:1.0.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0'

(with

android.enableJetifier=true
android.useAndroidX=true

in gradle.properties)
worked for me

sjudd · 2018-10-24T16:56:06Z

It sounds like this does in fact work, so I'm going to close this issue.

If anyone who has gotten it to work is interested, it would be great to have something on our setup page: http://bumptech.github.io/glide/doc/download-setup.html. There's documentation on contributing to that site here: http://bumptech.github.io/glide/dev/contributing.html#documentation

EmmanuelMess · 2018-12-09T20:53:33Z

@HimanshuNarang have you found a fix for this?:

But still having compile time error for
Glide.with((androidx.fragment.app.Fragment) fragmentInstance);
Cannot resolve method with androidx.fragment.app.Fragment

HimanshuNarang · 2018-12-10T06:03:08Z

I stopped using androidx. But I think according to @PiN73

implementation 'com.github.bumptech.glide:glide:4.8.0'
annotationProcessor 'androidx.annotation:annotation:1.0.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0'

(with

android.enableJetifier=true
android.useAndroidX=true

in gradle.properties)
worked for me

This will work.

EmmanuelMess · 2018-12-10T17:33:09Z

@HimanshuNarang Maybe I missed something, but I could not get the generated code to import androidx.fragment.app.Fragment (even using @PiN73's fix). It is the only problem I have yet to fix integrating Glide and AndroidX..

jackz314 · 2018-12-30T02:36:39Z

It sounds like this does in fact work, so I'm going to close this issue.

So when can we expect a stable release without the need of extra dependencies like the annotationProcessor? It's almost 2019 now.

TonyTangAndroid · 2019-01-28T04:53:21Z

@KevinLeigh Thank You. its working now

implementation 'com.github.bumptech.glide:glide:4.8.0-SNAPSHOT'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0-SNAPSHOT'
implementation 'com.github.bumptech.glide:okhttp3-integration:4.8.0-SNAPSHOT@aar'
implementation "com.android.support:support-annotations:28.0.0-alpha3"
annotationProcessor 'com.android.support:support-annotations:28.0.0-alpha3'

Thank you, man. One would not expect this could actually resolve the problem because "support-annotations" was not imported at the very beginning.

TonyTangAndroid · 2019-01-28T04:56:05Z

I did further test based on @KevinLeigh solution, it turns out that all we need is to add
annotationProcessor 'com.android.support:support-annotations:28.0.0'
which is something that I would not expect.

-bumptech/glide#3185 (comment)

eicky · 2019-03-13T09:01:38Z

use annotationProcessor 'androidx.annotation:annotation:1.0.0' can solve this problem

jmhabuild · 2019-08-07T08:06:48Z

If you are targeting for Android API 28(Pie) and Glide 4.9, then conform to this.

implementation 'com.github.bumptech.glide:glide:4.9.0'
annotationProcessor 'androidx.annotation:annotation:1.1.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.9.0'

wtnh · 2019-08-07T20:43:29Z

@jmhabuild has the correct answer; so if you are using androidx and Glide 4.9.0, add:
annotationProcessor 'androidx.annotation:annotation:1.1.0'
as he suggests. Worked for me.

Since I can't possibly be the only one who was still having problems generating the API, should this not be added to the docs?

IgorGanapolsky · 2019-09-24T16:37:42Z

I am getting the same error. Using glide 4.9.0. Any solution?

IkemNwodo · 2019-11-09T08:57:51Z

I can confirm using Glide version 4.8.0 works for me in combination with androidX.
Make sure to activate android.enableJetifier=true in your gradle.properties. In addition, I had to clean the project before I could finally get rid of various build errors and get it to work.
Found the tips here #3184 (comment) and confirmation on #3229 (comment)

A year later and your reply saved me. Thanks a lot!

luatnd · 2020-01-10T08:12:27Z

I am getting the same error. Using glide 4.9.0. Any solution?

Mee too.
There was the content of: build/generated/source/apt/debug/com/dylanvann/fastimage/GlideOptions.java

import android.support.annotation.CheckResult;
import android.support.annotation.NonNull;
import androidx.annotation.DrawableRes;
import androidx.annotation.FloatRange;

So I end-up with:
https://github.com/DylanVann/react-native-fast-image/blob/master/docs/app-glide-module.md

to solve my issue.

hungntv · 2020-01-12T06:50:57Z

implementation 'com.github.bumptech.glide:glide:4.8.0'
annotationProcessor 'androidx.annotation:annotation:1.0.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.8.0'

(with

android.enableJetifier=true
android.useAndroidX=true

in gradle.properties)
worked for me

It works for me

wtnh · 2020-01-12T18:33:02Z

FWIW, the following dependencies are working in my project with Glide 4.9.0 and SDK 28. I recall converting the project to androidx when I was using 4.8.0, then upgraded Glide to 4.9.0.

implementation 'androidx.appcompat:appcompat:1.1.0-rc01'
implementation 'com.google.android.material:material:1.1.0-alpha09'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
testImplementation 'junit:junit:4.12'
implementation 'androidx.recyclerview:recyclerview:1.1.0-beta03'
implementation 'androidx.cardview:cardview:1.0.0'
implementation 'com.android.volley:volley:1.1.1'
implementation 'com.github.chrisbanes:PhotoView:2.3.0'
implementation 'com.github.bumptech.glide:glide:4.9.0'
implementation 'com.github.bumptech.glide:annotations:4.9.0'
annotationProcessor 'androidx.annotation:annotation:1.1.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.9.0'
implementation 'com.google.code.gson:gson:2.8.5'

mochadwi · 2020-04-25T20:25:50Z

I can confirm using Glide version 4.8.0 works for me in combination with androidX.
Make sure to activate android.enableJetifier=true in your gradle.properties. In addition, I had to clean the project before I could finally get rid of various build errors and get it to work.
Found the tips here #3184 (comment) and confirmation on #3229 (comment)
@friederikewild

is clean you mean these steps:

invalidate caches & restart
delete `~./gradle/caches
delete /my_project/.idea & `/my_project/.gradle/
clean & rebuild project

the above steps still doesn't works for me, unless I'm using this step: facebook/facebook-android-sdk#591 (comment) (in my case Glide works with this)

But, the process doesn't succeed that ways, my other libraries also failed to build

Then I've created an SO Question about this migration (for future reader) and "temporary" approach for my problem when migrating to AndroidX

KevinLeigh changed the title ~~Glide compiler for AndroidX project partially supports androidx.annotation~~ Glide compiler for AndroidX project partially supports androidx.annotation namespace Jul 5, 2018

sjudd added the enhancement label Jul 19, 2018

burekas7 mentioned this issue Oct 18, 2018

Add Profile Image to Drawer using Facebook Url mikepenz/MaterialDrawer#1939

Closed

sjudd closed this as completed Oct 24, 2018

aaroncrutchfield added a commit to aaroncrutchfield/NatashasHairStudio that referenced this issue Feb 12, 2019

fix: Compile Errors caused by Glide partial support of AndroidX

aa43faa

-bumptech/glide#3185 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glide compiler for AndroidX project partially supports `androidx.annotation` namespace #3185

Glide compiler for AndroidX project partially supports `androidx.annotation` namespace #3185

KevinLeigh commented Jul 5, 2018

KevinLeigh commented Jul 5, 2018

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018 •

edited

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018 •

edited

KevinLeigh commented Jul 6, 2018

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018

kerjani commented Jul 10, 2018

Rajeshr34 commented Jul 10, 2018

mufumbo commented Jul 12, 2018

Shusshu commented Jul 26, 2018

mice777 commented Aug 15, 2018

friederikewild commented Aug 18, 2018

HimanshuNarang commented Sep 13, 2018

CnPeng commented Sep 26, 2018

PiN73 commented Oct 2, 2018 •

edited

sjudd commented Oct 24, 2018

EmmanuelMess commented Dec 9, 2018

HimanshuNarang commented Dec 10, 2018

EmmanuelMess commented Dec 10, 2018 •

edited

jackz314 commented Dec 30, 2018 •

edited

TonyTangAndroid commented Jan 28, 2019

TonyTangAndroid commented Jan 28, 2019

eicky commented Mar 13, 2019

jmhabuild commented Aug 7, 2019

wtnh commented Aug 7, 2019 •

edited

IgorGanapolsky commented Sep 24, 2019

IkemNwodo commented Nov 9, 2019

luatnd commented Jan 10, 2020

hungntv commented Jan 12, 2020 •

edited

wtnh commented Jan 12, 2020

mochadwi commented Apr 25, 2020 •

edited

Glide compiler for AndroidX project partially supports androidx.annotation namespace #3185

Glide compiler for AndroidX project partially supports androidx.annotation namespace #3185

Comments

KevinLeigh commented Jul 5, 2018

KevinLeigh commented Jul 5, 2018

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018 • edited

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018 • edited

KevinLeigh commented Jul 6, 2018

Rajeshr34 commented Jul 6, 2018

KevinLeigh commented Jul 6, 2018

kerjani commented Jul 10, 2018

Rajeshr34 commented Jul 10, 2018

mufumbo commented Jul 12, 2018

Shusshu commented Jul 26, 2018

mice777 commented Aug 15, 2018

friederikewild commented Aug 18, 2018

HimanshuNarang commented Sep 13, 2018

CnPeng commented Sep 26, 2018

PiN73 commented Oct 2, 2018 • edited

sjudd commented Oct 24, 2018

EmmanuelMess commented Dec 9, 2018

HimanshuNarang commented Dec 10, 2018

EmmanuelMess commented Dec 10, 2018 • edited

jackz314 commented Dec 30, 2018 • edited

TonyTangAndroid commented Jan 28, 2019

TonyTangAndroid commented Jan 28, 2019

eicky commented Mar 13, 2019

jmhabuild commented Aug 7, 2019

wtnh commented Aug 7, 2019 • edited

IgorGanapolsky commented Sep 24, 2019

IkemNwodo commented Nov 9, 2019

luatnd commented Jan 10, 2020

hungntv commented Jan 12, 2020 • edited

wtnh commented Jan 12, 2020

mochadwi commented Apr 25, 2020 • edited

Glide compiler for AndroidX project partially supports `androidx.annotation` namespace #3185

Glide compiler for AndroidX project partially supports `androidx.annotation` namespace #3185

KevinLeigh commented Jul 6, 2018 •

edited

KevinLeigh commented Jul 6, 2018 •

edited

PiN73 commented Oct 2, 2018 •

edited

EmmanuelMess commented Dec 10, 2018 •

edited

jackz314 commented Dec 30, 2018 •

edited

wtnh commented Aug 7, 2019 •

edited

hungntv commented Jan 12, 2020 •

edited

mochadwi commented Apr 25, 2020 •

edited