Skip to content

ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

howard-repos
Copy link
Contributor

In website, "Single System Image" is "A client will see the same view of the service regardless of the server that it connects to."

I want to change it to "Once connected, a client will see the same view of the service even if it switchs to another server"

Because the old one is a little misleading, if cluster has a outdated follower and a normal follower, I do not think a client will see the same view of the service regardless of the server that it connects to at its first connection.

@howard-repos
Copy link
Contributor Author

funny story, I just changed some MD documents, why checks faild?

@maoling
Copy link
Member

maoling commented May 7, 2019

@Kabike

  • the CI failure is not related.due to Installing oraclejdk11 , don't worry about this.
  • Yep,the description is a little misleading.IMO,What the "Single System Image" means is that a client cannot read the stale data that it had ever read regardless of the server that it connects to. e.g:
    set /key v1-->v2-->v3
    A client's view of the /key cannot be like: v1-->v3-->v2.
  • For the implement, when the client reconnect to another server, that server will refuse the connection when his current zxid is less than the client's lastZxid.

@howard-repos
Copy link
Contributor Author

@maoling yes, it is quite misleading. see https://stackoverflow.com/questions/40797443/how-zookeeper-guarantees-single-system-image. That is why I made this pull request

@anmolnar
Copy link
Contributor

@hanm @phunt Do you agree with this change?

@hanm
Copy link
Contributor

hanm commented May 30, 2019

I agree the original statement is not very clear, but instead of changing it, how about actually clarify it with this:

A client will see the same view of the service regardless of the server that it connects to, and a client will never see an older view of the system even if the client fails over to a different server with the same session.

@howard-repos
Copy link
Contributor Author

@hanm "A client will see the same view of the service regardless of the server that it connects to" sounds like "A client will see the same view of the service regardless of the server that it connects to at the first time", IMO

@maoling
Copy link
Member

maoling commented Jul 31, 2019

A client will see the same view of the service regardless of the server that it connects to. i.e., a client will never see an older view of the system even if the client fails over to a different server with the same session

Clarifying it is better than changing it, WDYT? @Kabike Can we move on?

@howard-repos
Copy link
Contributor Author

@maoling What should I do to move on?

@maoling
Copy link
Member

maoling commented Aug 1, 2019

@Kabike
Keep the original statement still and add a clarification behind it, just like this:

A client will see the same view of the service regardless of the server that it connects to. i.e., a client will never see an older view of the system even if the client fails over to a different server with the same session

Copy link
Member

@maoling maoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@asfgit asfgit closed this in f252c76 Aug 5, 2019
@howard-repos howard-repos deleted the ZOOKEEPER-3373 branch August 7, 2019 03:41
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
…rantee in document

In website, "Single System Image" is "A client will see the same view of the service regardless of the server that it connects to."

I want to change it to "Once connected, a client will see the same view of the service even if it switchs to another server"

Because the old one is a little misleading, if cluster has a outdated follower and a normal follower, I do not think a client will see the same view of the service regardless of the server that it connects to at its first connection.

Author: 数组越界 <ihavenoemail@163.com>

Reviewers: maoling <maoling199210191@sina.com>, Andor Molnár <andor@apache.org>, Michael Han <hanm@apache.org>

Closes apache#931 from kabike/ZOOKEEPER-3373
@WenXiangWu
Copy link

It is very misleading

@eolivelli
Copy link
Contributor

@Michealwwx can you please tell us more ?

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
…rantee in document

In website, "Single System Image" is "A client will see the same view of the service regardless of the server that it connects to."

I want to change it to "Once connected, a client will see the same view of the service even if it switchs to another server"

Because the old one is a little misleading, if cluster has a outdated follower and a normal follower, I do not think a client will see the same view of the service regardless of the server that it connects to at its first connection.

Author: 数组越界 <ihavenoemail@163.com>

Reviewers: maoling <maoling199210191@sina.com>, Andor Molnár <andor@apache.org>, Michael Han <hanm@apache.org>

Closes apache#931 from kabike/ZOOKEEPER-3373
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
…rantee in document

In website, "Single System Image" is "A client will see the same view of the service regardless of the server that it connects to."

I want to change it to "Once connected, a client will see the same view of the service even if it switchs to another server"

Because the old one is a little misleading, if cluster has a outdated follower and a normal follower, I do not think a client will see the same view of the service regardless of the server that it connects to at its first connection.

Author: 数组越界 <ihavenoemail@163.com>

Reviewers: maoling <maoling199210191@sina.com>, Andor Molnár <andor@apache.org>, Michael Han <hanm@apache.org>

Closes apache#931 from kabike/ZOOKEEPER-3373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants