[Feature][Issue-2191][Issue-2215] Support external link #2331 #2375
+1,192
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saLeox
force-pushed
the
support_external_link
branch
from
5a34466 to
b9155ee
Compare
|
cc @wangsizhu0504 PTAL. thx |
streampark-console/streampark-console-webapp/src/api/flink/setting/types/externalLink.type.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #2191 #2215
Brief change log
There should be a place to hold and display the useful external link (such as Job Metrics / Savepoint root path, etc) for each Flink Job.
This feature will allow user to customise their own external link, display it as a badge inside the Flink Application detail page, and jump to other page after clicking it.
For example, I am using Grafana, the link url format will be fixed in the following way:
https://grafana/{template_name}/flink-monitoring?var-JobId=var-JobId={job_id}
The value of place holder, job_id, can be fetched from existing meta data of Flink Job easily.
Outcome:
The links are bound with each Flink Job, and the place holders are replaced automatically with actual value.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts