Skip to content

[SCB-2347] Bump netty version to 4.1.68 vertx version to 4.1.5 #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2021

Conversation

hezhangjian
Copy link
Member

No description provided.

@hezhangjian
Copy link
Member Author

@liubao68 PTAL

@develpoerX
Copy link
Contributor

need to run workflows

@hezhangjian
Copy link
Member Author

need to run workflows

Thanks for your attention, but I need a maintainer approve to run workflows

@liubao68
Copy link
Contributor

There are test failures need to be resolved

@hezhangjian
Copy link
Member Author

@liubao68 It seems vertx change the default value of HttpServerOptions.DEFAULT_MAX_FORM_ATTRIBUTE_SIZE, what should we do ?

Copy link

@DInTheName DInTheName left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当netty的版本升级到4.1.68.Final时,请注意netty-tcnative-boringssl-static的版本需要升级到2.0.43.Final,这个包是org.apache.servicecomb:foundation-ssl:jar引入的,目前我们使用的是servicecomb的2.1.5版本,netty-tcnative-boringssl-static的版本为2.0.34.Final。
如果netty-tcnative-boringssl-static不升级的话,会导致如下错误,请注意:
image

@hezhangjian
Copy link
Member Author

当netty的版本升级到4.1.68.Final时,请注意netty-tcnative-boringssl-static的版本需要升级到2.0.43.Final,这个包是org.apache.servicecomb:foundation-ssl:jar引入的,目前我们使用的是servicecomb的2.1.5版本,netty-tcnative-boringssl-static的版本为2.0.34.Final。 如果netty-tcnative-boringssl-static不升级的话,会导致如下错误,请注意: image

Thank you, I will bump this dep too.

@liubao68
Copy link
Contributor

I created a subtask to update release notes about this change. Would you mind to create a PR for this doc?
see https://servicecomb.apache.org/references/java-chassis/zh_CN/featured-topics/upgrading.html
and source https://github.com/apache/servicecomb-docs

@liubao68 liubao68 merged commit 4ddd153 into apache:master Oct 30, 2021
@hezhangjian
Copy link
Member Author

I created a subtask to update release notes about this change. Would you mind to create a PR for this doc? see https://servicecomb.apache.org/references/java-chassis/zh_CN/featured-topics/upgrading.html and source https://github.com/apache/servicecomb-docs

I am happy to do this work. But I saw the vertx project, they does not change this value since 2015
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants