[ISSUE #3585] [Part H] Avoid unnecessary StringBuilder resizing on critical path #3612
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zanglei06
changed the title
Zanglei06
force-pushed
the
improve_build_key_dev
branch
from
c97ae34 to
41832f7
Compare
areyouok
approved these changes
Dec 9, 2021
panzhi33
approved these changes
Dec 9, 2021
Codecov Report
@@ Coverage Diff @@
## develop #3612 +/- ##
==========================================
Coverage 48.82% 48.82%
- Complexity 4643 4652 +9
==========================================
Files 555 555
Lines 36721 36727 +6
Branches 4835 4840 +5
==========================================
+ Hits 17930 17933 +3
- Misses 16539 16545 +6
+ Partials 2252 2249 -3
Continue to review full report at Codecov.
|
yuz10
approved these changes
Dec 10, 2021
francisoliverlee
changed the title
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
…tical path (apache#3612) Co-authored-by: zanglei <zanglei@kuaishou.com>
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…tical path (apache#3612) Co-authored-by: zanglei <zanglei@kuaishou.com>
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
…tical path (apache#3612) Co-authored-by: zanglei <zanglei@kuaishou.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.apache.rocketmq.broker.longpolling.PullRequestHoldService#buildKey is called 2 times per msg when long polling is enabled. It is better to give a capacity needed.