Skip to content

[ISSUE #3585] [Part F] eliminate regex match in topic/group name check #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

[ISSUE #3585] [Part F] eliminate regex match in topic/group name check #3594

merged 1 commit into from
Dec 9, 2021
+49 −52

Conversation

shuangchengsun
Copy link
Contributor

use bit map to replace regex.

@shuangchengsun shuangchengsun reopened this Dec 7, 2021
@areyouok areyouok linked an issue Dec 7, 2021 that may be closed by this pull request
Improve performance for 4.9.2 #3585
Closed
@coveralls
Copy link

coveralls commented Dec 7, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 55.087% when pulling 03668ea on shuangchengsun:492-f into 4d49551 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #3594 (75a1563) into develop (4d49551) will increase coverage by 0.04%.
The diff coverage is 88.46%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3594      +/-   ##
=============================================
+ Coverage      48.71%   48.75%   +0.04%     
- Complexity      4638     4647       +9     
=============================================
  Files            555      555              
  Lines          36733    36744      +11     
  Branches        4836     4845       +9     
=============================================
+ Hits           17893    17914      +21     
+ Misses         16596    16578      -18     
- Partials        2244     2252       +8
Impacted Files Coverage Δ
...in/java/org/apache/rocketmq/client/Validators.java 55.55% <50.00%> (+5.55%) ⬆️
...g/apache/rocketmq/common/topic/TopicValidator.java 96.82% <95.45%> (+3.07%) ⬆️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.28% <0.00%> (-0.67%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.94% <0.00%> (-0.25%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 74.51% <0.00%> (-0.20%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...apache/rocketmq/client/trace/TraceDataEncoder.java 69.73% <0.00%> (+0.20%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.71% <0.00%> (+0.49%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d49551...75a1563. Read the comment docs.

@yuz10 yuz10 merged commit 50d45f2 into apache:develop Dec 9, 2021
@yuz10 yuz10 added this to the 4.9.3 milestone Dec 10, 2021
@francisoliverlee francisoliverlee changed the title [ISSUE 3585] [Part F] eliminate regex match in topic/group name check [ISSUE #3585] [Part F] eliminate regex match in topic/group name check Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
@shuangchengsun
[ISSUE 3585] [Part F] eliminate regex match in topic/group name check (…
ab5c3b2 
…apache#3594)
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
@shuangchengsun
[ISSUE 3585] [Part F] eliminate regex match in topic/group name check (…
fa5e380 
…apache#3594)
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
@shuangchengsun
[ISSUE 3585] [Part F] eliminate regex match in topic/group name check (…
7861c3d 
…apache#3594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areyouok areyouok

@yuz10 yuz10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

Improve performance for 4.9.2
5 participants
@shuangchengsun @coveralls @codecov-commenter @areyouok @yuz10