Skip to content

[ISSUE 3585] [Part E] eliminate duplicated getNamespace() call when where is no namespace #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

areyouok
Copy link
Contributor

@areyouok areyouok commented Dec 6, 2021

this commit eliminate this method from flame graph in producer side.

@areyouok areyouok linked an issue Dec 6, 2021 that may be closed by this pull request
@areyouok
Copy link
Contributor Author

areyouok commented Dec 6, 2021

This PR also target issue #3426

and I modified based on #3427

@areyouok areyouok linked an issue Dec 6, 2021 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 55.107% when pulling 4316d91 on areyouok:492_PartE into 4daade3 on apache:develop.

@yuz10 yuz10 merged commit 67225fd into apache:develop Dec 11, 2021
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
…here is no namespace (apache#3591)

Co-authored-by: colin <39513055@qq.com>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…here is no namespace (apache#3591)

Co-authored-by: colin <39513055@qq.com>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
…here is no namespace (apache#3591)

Co-authored-by: colin <39513055@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance for 4.9.2 reduce unnecessary regex matches when namespace is null
5 participants