Skip to content

[ISSUE 3585] [Part C] cache the result of parseChannelRemoteAddr() #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

areyouok
Copy link
Contributor

@areyouok areyouok commented Dec 6, 2021

cache the result of parseChannelRemoteAddr() and eliminate this method in flame graph.

used 4.84% cpu before this commit in producer side

@areyouok areyouok linked an issue Dec 6, 2021 that may be closed by this pull request
…d eliminate this method in flame graph. (used 4.84% cpu before this commit in producer side)
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 55.099% when pulling 1995940 on areyouok:492_PartC into 4d49551 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3589 (1995940) into develop (4daade3) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3589   +/-   ##
==========================================
  Coverage      48.77%   48.78%           
- Complexity      4645     4649    +4     
==========================================
  Files            555      555           
  Lines          36733    36742    +9     
  Branches        4836     4838    +2     
==========================================
+ Hits           17916    17924    +8     
  Misses         16568    16568           
- Partials        2249     2250    +1     
Impacted Files Coverage Δ
...pache/rocketmq/remoting/common/RemotingHelper.java 19.78% <77.77%> (+6.36%) ⬆️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.57% <0.00%> (-0.98%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.39% <0.00%> (-0.94%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 39.64% <0.00%> (-0.53%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 70.95% <0.00%> (-0.34%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 56.23% <0.00%> (+0.19%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.31%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daade3...1995940. Read the comment docs.

@duhenglucky duhenglucky merged commit e4394b6 into apache:develop Dec 20, 2021
tianliuliu pushed a commit to tianliuliu/rocketmq that referenced this pull request Dec 21, 2021
…d eliminate this method in flame graph. (used 4.84% cpu before this commit in producer side) (apache#3589)
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
…d eliminate this method in flame graph. (used 4.84% cpu before this commit in producer side) (apache#3589)
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…d eliminate this method in flame graph. (used 4.84% cpu before this commit in producer side) (apache#3589)
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
…d eliminate this method in flame graph. (used 4.84% cpu before this commit in producer side) (apache#3589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance for 4.9.2
6 participants