[ISSUE 3585] [Part A] eliminate reverse DNS lookup in MessageExt #3586
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuz10
approved these changes
Dec 8, 2021
RongtongJin
approved these changes
Dec 10, 2021
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageExt.getBornHostNameString() called InetAddress.getHostName(), which may case reverse DNS lookup.
MessageExt.getBornHostNameString() is used in broker side, so we use InetSocketAddress.getHostString() instead it.