Skip to content

check null to avoid NPE for internalSetTopicPolicies #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

check null to avoid NPE for internalSetTopicPolicies #8201

merged 1 commit into from
Oct 5, 2020
+23 −9

Conversation

hangc0276
Copy link
Contributor

Motivation & Changes

  1. add null check for topic policies to avoid NPE
  2. add boundary check for MaxUnackedMessagesOnSubscription and SetMaxUnackedMessagesOnConsumer

@codelipenghui codelipenghui requested review from jiazhai and sijie October 4, 2020 12:52
@codelipenghui codelipenghui added this to the 2.7.0 milestone Oct 4, 2020
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie merged commit 7a1be70 into apache:master Oct 5, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
@hangc0276 @huangdx0726
check null to avoid NPE for internalSetTopicPolicies (apache#8201)
854c088 
### Motivation & Changes
1. add null check for topic policies to avoid NPE
2. add boundary check for `MaxUnackedMessagesOnSubscription` and `SetMaxUnackedMessagesOnConsumer`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie

@codelipenghui codelipenghui

@jiazhai jiazhai

Assignees

@hangc0276 hangc0276

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hangc0276 @sijie @codelipenghui