add epoch for C++ client HandleBase to handle create producer timeout #8191
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Oct 3, 2020
|
@BewareMyPower Would you please also take a look if you have time? |
|
@jiazhai I've had a look at this PR just right. LGTM. Just one point, I'm not sure that if should |
sijie
approved these changes
Oct 5, 2020
1 task
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
…#8191) Fix #8124 ### Changes Related to `PR-5571`, I add epoch on `HandleBase` for C++ Client. Due to C++ client not expose handler interface to producer client, i can't add epoch test in the test case. I doubt whether to expose those interfaces to get handler instance and epoch just for test case. Please take a look and give me some ideas. @sijie @jiazhai @codelipenghui (cherry picked from commit 8572ffb)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
…apache#8191) Fix apache#8124 ### Changes Related to `PR-5571`, I add epoch on `HandleBase` for C++ Client. Due to C++ client not expose handler interface to producer client, i can't add epoch test in the test case. I doubt whether to expose those interfaces to get handler instance and epoch just for test case. Please take a look and give me some ideas. @sijie @jiazhai @codelipenghui
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
…apache#8191) Fix apache#8124 ### Changes Related to `PR-5571`, I add epoch on `HandleBase` for C++ Client. Due to C++ client not expose handler interface to producer client, i can't add epoch test in the test case. I doubt whether to expose those interfaces to get handler instance and epoch just for test case. Please take a look and give me some ideas. @sijie @jiazhai @codelipenghui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8124
Changes
Related to
PR-5571, I add epoch onHandleBasefor C++ Client.Due to C++ client not expose handler interface to producer client, i can't add epoch test in the test case. I doubt whether to expose those interfaces to get handler instance and epoch just for test case.
Please take a look and give me some ideas. @sijie @jiazhai @codelipenghui