Skip to content

Issue 8187 pulsar-dashboard django migration fix #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Issue 8187 pulsar-dashboard django migration fix #8188

merged 1 commit into from
Oct 5, 2020

Conversation

sbourkeostk
Copy link
Contributor

@sbourkeostk sbourkeostk commented Oct 2, 2020

Fixes #8187

Motivation

The length of the consumerName in pulsar-dashboard's django model was increased to 256 in #4716 however the change was not propagated by the django migrations system. The existing migrations result in a size of 64:

('consumerName', models.CharField(max_length=64, null=True)),

This pull request fixes this. ./manage.py makemigrations was used to generate this migration.

Modifications

An additional django migration file is included to update the db to match the model.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why? It's a small bugfix.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@sbourkeostk
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@sijie sijie added this to the 2.7.0 milestone Oct 2, 2020
@sijie sijie added component/dashboard type/bug The PR fixed a bug or issue reported a bug release/2.6.2 labels Oct 2, 2020
@sijie sijie merged commit 88238b3 into apache:master Oct 5, 2020
@sbourkeostk sbourkeostk deleted the fix-8187 branch October 6, 2020 09:50
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
Fixes #8187

### Motivation

The length of the consumerName in pulsar-dashboard's django model was increased to 256 in #4716 however the change was not propagated by the django migrations system. The existing migrations result in a size of 64:
https://github.com/apache/pulsar/blob/e65875b99e3985630e3147c2579e91da4c3973bf/dashboard/django/stats/migrations/0001_initial.py#L56

This pull request fixes this. `./manage.py makemigrations` was used to generate this migration.

### Modifications

An additional django migration file is included to update the db to match the model.

(cherry picked from commit 88238b3)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
Fixes apache#8187

### Motivation

The length of the consumerName in pulsar-dashboard's django model was increased to 256 in apache#4716 however the change was not propagated by the django migrations system. The existing migrations result in a size of 64:
https://github.com/apache/pulsar/blob/e65875b99e3985630e3147c2579e91da4c3973bf/dashboard/django/stats/migrations/0001_initial.py#L56

This pull request fixes this. `./manage.py makemigrations` was used to generate this migration.

### Modifications

An additional django migration file is included to update the db to match the model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.6.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulsar-dashboard: ERROR: value too long for type character varying(64)
2 participants