[pulsar-admin-tools] Support delete all data associated with a cluster #8133
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
2 tasks
|
/pulsarbot run-failure-checks |
jiazhai
changed the title
|
lgtm， @BewareMyPower would you please open a new issue for the todo item, and linked in your code comments |
jiazhai
approved these changes
Sep 26, 2020
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jiazhai
changed the title
|
/pulsarbot run-failure-checks |
|
pulsarbot run-failure-checks |
BewareMyPower
force-pushed
the
delete-cluster-dev
branch
from
0e052f3 to
62d3b5e
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
BewareMyPower
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Oct 1, 2020
apache#8133) ### Motivation When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted. ### Modifications - Add an option to `cluster delete` command to delete all the data associated with the cluster. Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. ### Verifying this change The new option has been tested in local environment by: 1. Deploy a ZK which acts as both local ZK and the configuration store; 2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position; 3. Deploy a BK; 4. Deploy 2 brokers associated with the 2 clusters' metadata; 5. Create some topics and produce some messages to 2 clusters; 6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count. **An integration test is needed to simulate the procedures above.**
BewareMyPower
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Oct 1, 2020
apache#8133) ### Motivation When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted. ### Modifications - Add an option to `cluster delete` command to delete all the data associated with the cluster. Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. ### Verifying this change The new option has been tested in local environment by: 1. Deploy a ZK which acts as both local ZK and the configuration store; 2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position; 3. Deploy a BK; 4. Deploy 2 brokers associated with the 2 clusters' metadata; 5. Create some topics and produce some messages to 2 clusters; 6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count. **An integration test is needed to simulate the procedures above.**
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
apache#8133) ### Motivation When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted. ### Modifications - Add an option to `cluster delete` command to delete all the data associated with the cluster. Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. ### Verifying this change The new option has been tested in local environment by: 1. Deploy a ZK which acts as both local ZK and the configuration store; 2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position; 3. Deploy a BK; 4. Deploy 2 brokers associated with the 2 clusters' metadata; 5. Create some topics and produce some messages to 2 clusters; 6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count. **An integration test is needed to simulate the procedures above.**
|
need to cherry-pick 2.6.2. |
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
#8133) ### Motivation When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted. ### Modifications - Add an option to `cluster delete` command to delete all the data associated with the cluster. Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. ### Verifying this change The new option has been tested in local environment by: 1. Deploy a ZK which acts as both local ZK and the configuration store; 2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position; 3. Deploy a BK; 4. Deploy 2 brokers associated with the 2 clusters' metadata; 5. Create some topics and produce some messages to 2 clusters; 6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count. **An integration test is needed to simulate the procedures above.** (cherry picked from commit 0b041a2)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
apache#8133) ### Motivation When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted. ### Modifications - Add an option to `cluster delete` command to delete all the data associated with the cluster. Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. ### Verifying this change The new option has been tested in local environment by: 1. Deploy a ZK which acts as both local ZK and the configuration store; 2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position; 3. Deploy a BK; 4. Deploy 2 brokers associated with the 2 clusters' metadata; 5. Create some topics and produce some messages to 2 clusters; 6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count. **An integration test is needed to simulate the procedures above.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted.
Modifications
cluster deletecommand to delete all the data associated with the cluster.Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed
SchemaRegistryServiceImpl#deleteSchema's semantics should be change.Verifying this change
The new option has been tested in local environment by:
--bookkeeper-metadata-serviceoption to share the same BK metadata position;bin/pulsar cluster -all <cluster>to delete the whole cluster, usebin/bookkeeper shell list ledgersto verify the change of ledgers count.An integration test is needed to simulate the procedures above.