[pulsar-broker] Added support to force deleting tenant #8103
Conversation
Jennifer88huang-zz
requested review from
merlimat,
jiazhai and
massakam
and removed request for
merlimat and
jiazhai
|
I've fixed the |
| // Check deleting non-existing property | ||
| try { | ||
| properties.deleteTenant("non-existing"); | ||
| properties.deleteTenant(response, "non-existing", false); |
There was a problem hiding this comment.
Is the test related to this change? I think the test should cover there are namespaces and topics under a tenant, then we delete the tenant forcefully should success.
There was a problem hiding this comment.
This change adds a force option so the test need pass this option. I can add a test to cover the above situations later.
|
move to 2.8.0 first |
@codelipenghui I can add a test to cover your comments and we expect this feature as soon as possilbe. Can this be introduced in coming 2.7.0? |
|
@codelipenghui @jiazhai I have added a test, please help to take a review when available, thanks. |
|
/pulsarbot run-failure-checks |
|
Close this and submit a new pull request using metadata-api. |
Motivation
Some users expect an option to force deleting tenant for simplicity, it can be useful in some situations.
Modifications
Add a optional field to force the deletion of all stuffs related to tenant.