Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transaction] Fix transaction message ack #8007

Merged
merged 7 commits into from
Sep 16, 2020
Merged

[Transaction] Fix transaction message ack #8007

merged 7 commits into from
Sep 16, 2020
+197 −54

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Sep 8, 2020

Motivation

The transaction message ack is not well.

Modifications

Fix the transaction message ack.

Verifying this change

This change added tests and can be verified as follows:

-org.apache.pulsar.client.transaction.EndToEndTest#txnBatchMessageAckTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.7.0 milestone Sep 16, 2020
@codelipenghui codelipenghui merged commit 77fca3e into apache:master Sep 16, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Oct 3, 2020
@gaoran10
[Transaction] Fix transaction message ack (apache#8007)
4befb70 
### Motivation

The transaction message ack is not well.

### Modifications

Fix the transaction message ack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui

Assignees

@gaoran10 gaoran10

Labels
area/transaction
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaoran10 @codelipenghui