Skip to content

[Transaction] Support transaction abort on partition #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

[Transaction] Support transaction abort on partition #7953

merged 2 commits into from
Sep 2, 2020
+183 −58

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Sep 2, 2020 •
edited
Loading

Fixes https://github.com/streamnative/pulsar/issues/1312

Motivation

Currently, the transaction abort on partitions operation is not getting through.

Modifications

Make the transaction abort on partitions operation get through.

Verifying this change

This change added tests and can be verified as follows:

  • org.apache.pulsar.broker.transaction.TransactionProduceTest#produceAndAbortTest
  • org.apache.pulsar.client.transaction.EndToEndTest#partitionAbortTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui added this to the 2.7.0 milestone Sep 2, 2020
@codelipenghui codelipenghui merged commit 3ac98d8 into apache:master Sep 2, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
[Transaction] Support transaction abort on partition (apache#7953)
7d05c3a 
Fixes https://github.com/streamnative/pulsar/issues/1312

# Motivation

Currently, the transaction abort on partitions operation is not getting through.

### Modifications

Make the transaction abort on partitions operation get through.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
[Transaction] Support transaction abort on partition (apache#7953)
5446d44 
Fixes https://github.com/streamnative/pulsar/issues/1312

# Motivation

Currently, the transaction abort on partitions operation is not getting through.

### Modifications

Make the transaction abort on partitions operation get through.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
[Transaction] Support transaction abort on partition (apache#7953)
d1068bd 
Fixes https://github.com/streamnative/pulsar/issues/1312

# Motivation

Currently, the transaction abort on partitions operation is not getting through.

### Modifications

Make the transaction abort on partitions operation get through.
@gaoran10 gaoran10 mentioned this pull request Nov 5, 2020
Closed
50 tasks
This was referenced Nov 21, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui

Assignees

@gaoran10 gaoran10

Labels
area/transaction
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

[Transaction] Transaction abort on topic partition
2 participants
@gaoran10 @codelipenghui