[Transaction] Handle Acknowledge In The Transaction #7856
Merged
+500
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
force-pushed
the
handle-ack-in-txn
branch
from
429d5ae to
40bb080
Compare
|
/pulsarbot run-failure-checks |
sijie
added
area/transaction
type/feature
gaoran10
force-pushed
the
handle-ack-in-txn
branch
from
3b7d11f to
048cf9e
Compare
|
/pulsarbot run-failure-checks |
| public void addSubscriptionToTxn(TxnID txnID, String topic, String subscription) | ||
| throws TransactionCoordinatorClientException { | ||
| try { | ||
| addSubscriptionToTxnAsync(txnID, topic, subscription); |
There was a problem hiding this comment.
The method will return before processing the add subscription to the txn, is this an expected behavior?
There was a problem hiding this comment.
I miss calling the get().
| .setTopic(topic) | ||
| .setSubscription(subscription) | ||
| .build(); | ||
| return handler.addSubscriptionToTxn(txnID, Lists.newArrayList(sub)); |
There was a problem hiding this comment.
The Singleton list is more suitable here. Or maybe you add a thread-local list to avoid introduce many list instance
Comment on lines
222
to
224
| } else { | ||
| // Unsupported txnStatus | ||
| commitFuture.completeExceptionally(new Throwable("Unsupported txnStatus.")); |
There was a problem hiding this comment.
Why remove this branch?
Comment on lines
1210
to
1211
| // dispatcher.redeliverUnacknowledgedMessages(consumer, (List<PositionImpl>) | ||
| // (List<?>)pendingAckMessageForCurrentTxn.values()); |
There was a problem hiding this comment.
Is this a useful change?
There was a problem hiding this comment.
No, I'll revert this.
| */ | ||
| @Data | ||
| @Builder | ||
| public class TransactionSubscription implements Comparable<TransactionSubscription> { |
There was a problem hiding this comment.
There is the same struct in PulsarApi.proto named Subscription, maybe you can use that one directly.
There was a problem hiding this comment.
There is a problem, I can't override the hashCode method of the Subscription and it can't be used in a Set collection.
gaoran10
force-pushed
the
handle-ack-in-txn
branch
from
7e07070 to
fb9ddf0
Compare
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 4, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fix https://github.com/streamnative/pulsar/issues/1307 Master Issue: apache#2664 ### Motivation Handle acknowledge in the transaction. ### Modifications 1. Register subscription to the transaction metadata store. 2. Make the ack command carry the transaction information. 3. When committing a transaction, commit every subscription in the transaction.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fix https://github.com/streamnative/pulsar/issues/1307 Master Issue: apache#2664 ### Motivation Handle acknowledge in the transaction. ### Modifications 1. Register subscription to the transaction metadata store. 2. Make the ack command carry the transaction information. 3. When committing a transaction, commit every subscription in the transaction.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fix https://github.com/streamnative/pulsar/issues/1307 Master Issue: apache#2664 ### Motivation Handle acknowledge in the transaction. ### Modifications 1. Register subscription to the transaction metadata store. 2. Make the ack command carry the transaction information. 3. When committing a transaction, commit every subscription in the transaction.
codelipenghui
removed
component/transaction
type/feature
50 tasks
This was referenced Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/streamnative/pulsar/issues/1307
Master Issue: #2664
Motivation
Handle acknowledge in the transaction.
Modifications
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation