[Transaction] Consume transaction message logic optimized #7833
+392
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
changed the title
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
txn-consume-message-batch-index
branch
2 times, most recently
from
010d775 to
ea9bbaf
Compare
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Comment on lines
2862
to
2866
| if (!batchDeletedIndexes.containsKey(position)) { | ||
| BitSetRecyclable bitSetRecyclable = BitSetRecyclable.create(); | ||
| bitSetRecyclable.set(0, totalNumMessageInBatch); | ||
| batchDeletedIndexes.put(position, bitSetRecyclable); | ||
| } |
There was a problem hiding this comment.
batchDeletedIndexes.computeIfAbsent().
There was a problem hiding this comment.
I'll use this method instead.
|
|
||
| - name: run unit tests for pulsar-broker | ||
| if: steps.docs.outputs.changed_only == 'no' | ||
| run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker -Dinclude='org/apache/pulsar/broker/**/*.java' -Dexclude='org/apache/pulsar/broker/zookeeper/**/*.java,org/apache/pulsar/broker/loadbalance/**/*.java,org/apache/pulsar/broker/service/**/*.java,**/AdminApiOffloadTest.java,**/TransactionProduceTest.java' | ||
| run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker -Dinclude='org/apache/pulsar/broker/**/*.java' -Dexclude='org/apache/pulsar/broker/zookeeper/**/*.java,org/apache/pulsar/broker/loadbalance/**/*.java,org/apache/pulsar/broker/service/**/*.java,**/AdminApiOffloadTest.java,org/apache/pulsar/broker/transaction/**/*.java,org/apache/pulsar/client/transaction/**/*.java' |
There was a problem hiding this comment.
Shall we need this change?
gaoran10
force-pushed
the
txn-consume-message-batch-index
branch
from
b19df42 to
fde7cd4
Compare
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Aug 31, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation The transaction message consuming logic needs to be optimized. One transaction commit marker in the topic partition consists of many Entries in the TransactionBuffer, so one transaction could be seen as one batch. ### Modifications 1. When sending messages to consumers use the `batchIndex` in the MessageIdData to present the startBatchIndex of the Entry. 2. Calculate the transaction messages number. 3. When the first reading one transaction init it's batchDeletedIndexes in the ManagedCursorImpl.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation The transaction message consuming logic needs to be optimized. One transaction commit marker in the topic partition consists of many Entries in the TransactionBuffer, so one transaction could be seen as one batch. ### Modifications 1. When sending messages to consumers use the `batchIndex` in the MessageIdData to present the startBatchIndex of the Entry. 2. Calculate the transaction messages number. 3. When the first reading one transaction init it's batchDeletedIndexes in the ManagedCursorImpl.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation The transaction message consuming logic needs to be optimized. One transaction commit marker in the topic partition consists of many Entries in the TransactionBuffer, so one transaction could be seen as one batch. ### Modifications 1. When sending messages to consumers use the `batchIndex` in the MessageIdData to present the startBatchIndex of the Entry. 2. Calculate the transaction messages number. 3. When the first reading one transaction init it's batchDeletedIndexes in the ManagedCursorImpl.
codelipenghui
added
component/transaction
area/transaction
and removed
component/transaction
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The transaction message consuming logic needs to be optimized. One transaction commit marker in the topic partition consists of many Entries in the TransactionBuffer, so one transaction could be seen as one batch.
Modifications
When sending messages to consumers use the
batchIndexin the MessageIdData to present the startBatchIndex of the Entry.Calculate the transaction messages number.
When the first reading one transaction init it's batchDeletedIndexes in the ManagedCursorImpl.
Verifying this change
This change can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation