Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgmentsGroupingTracker #7828

Merged
merged 2 commits into from Aug 18, 2020
Merged

Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgmentsGroupingTracker #7828

merged 2 commits into from Aug 18, 2020

Conversation

gaoran10
Copy link
Contributor

Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

Modifications

Fix the bitSet batchSize.

Verifying this change

This change can be verified as follows:

  • org.apache.pulsar.client.impl.BatchMessageIndexAckTest.testBatchMessageIndexAckForSharedSubscription

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui added this to the 2.7.0 milestone Aug 17, 2020
@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 23d795c into apache:master Aug 18, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@gaoran10 @huangdx0726
Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgme…
e236810 
…ntsGroupingTracker (apache#7828)

### Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

### Modifications

Fix the bitSet batchSize.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgme…
6460759 
…ntsGroupingTracker (apache#7828)

### Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

### Modifications

Fix the bitSet batchSize.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgme…
d85a435 
…ntsGroupingTracker (apache#7828)

### Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

### Modifications

Fix the bitSet batchSize.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@gaoran10
Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgme…
a46f7cc 
…ntsGroupingTracker (apache#7828)

### Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

### Modifications

Fix the bitSet batchSize.
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
@gaoran10 @wolfstudy
Fix pending batchIndexAcks bitSet batchSize in PersistentAcknowledgme…
3afae9b 
…ntsGroupingTracker (#7828)

### Motivation

The pending batchIndexAcks bitSet batchSize is not correct.

### Modifications

Fix the bitSet batchSize.

(cherry picked from commit 23d795c)
@gaoran10 gaoran10 deleted the fix-pending-batch-index-acks-size branch November 1, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@jiazhai jiazhai Awaiting requested review from jiazhai

@sijie sijie Awaiting requested review from sijie

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@gaoran10 gaoran10

Labels
release/2.6.2
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaoran10 @codelipenghui